Merge pull request 'dev' (#8) from dev into main #15

Covers input validation, JWT-based authorization enforcement, and
per-user rate limiting via Bucket4j.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

docs: add security hardening implementation plan efe84942ff

8-task TDD plan covering input validation, JWT-based authorization
enforcement, and Bucket4j rate limiting.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

build: add spring-boot-starter-validation and bucket4j-core b7db35defe

feat: add Bean Validation annotations to request models 3bea06fead

feat: add GlobalExceptionHandler, @Valid to user creation, AuthenticatedUserResolver stub, and rewrite ExpenseListController with authorization a948bca2fc

feat: add ExpenseListController validation and authorization tests bb2a4d70b2

test: add unit tests for AuthenticatedUserResolver 95688e5111

security: enforce JWT-based authorization on AppUserController 457efab452

Added AuthenticatedUserResolver injection and assertSelf guard to
getUser, getUserByGoogleId, and deleteUser endpoints. createUser
remains open for registration. Added 7 controller tests covering
validation failures and 403 enforcement.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

security: add per-user/IP rate limiting via Bucket4j 024b3880e7

RateLimitFilter (OncePerRequestFilter) enforces 60 req/min per
authenticated Google ID or client IP, using Bucket4j in-memory
token buckets. Filter is registered after BearerTokenAuthenticationFilter
in the production security chain. Added 4 unit tests covering
allow, block, per-IP isolation, and X-Forwarded-For preference.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

test: fix ExpenseListRepositoryTest with H2 and proper save-then-find pattern 9c91da9f30

Added H2 as a test-scoped dependency so @DataJpaTest has an embedded
database. Rewrote the test to save an entity and assert on the returned
ID rather than assuming a record exists at ID=1.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

fix: throw ResourceNotFoundException instead of returning null, replace full-table-scan list queries with JPQL 68783cc892

fix: single-param JPQL queries, ResourceNotFoundException throughout ExpenseListService, remove addExpenseToList loop 906b60d264

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

fix: use ResourceNotFoundException for not-found cases in updateExpense, IllegalArgumentException for ownership mismatch in deleteCustomCategory 797d482ebf

Remove docs from tracking 2bd229cc5e

fix: add /docs/superpowers to .gitignore 9b95741292

fix: centralise error handling in GlobalExceptionHandler, add SLF4J logging, remove HTTP 417 and e.printStackTrace() f0de751da4

- Expand GlobalExceptionHandler with handlers for ResourceNotFoundException (404),
  UsernameAlreadyExistsException (409), ResponseStatusException (pass-through),
  RuntimeException (500), and generic Exception (500); add SLF4J logging
- Remove all bare try/catch blocks and e.printStackTrace() calls from
  ExpenseListController; add SLF4J logger field
- Add test: create_returns500_onUnexpectedServiceError

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

security hardening (#12 ) 19c7e1915f

Reviewed-on: #12
Co-authored-by: Cedric Hornberger <ceddi.hornberger@gmx.de>
Co-committed-by: Cedric Hornberger <ceddi.hornberger@gmx.de>

feat: add CreateExpenseListRequest DTO with validation to POST /create endpoint 8b96433b1a

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

test: add jsonPath field assertions to create validation tests b1324e3048

Bugfixes 3d456f2f81

docs: scaffold API.md with section headings 9c35bb8435

docs: write API overview section 8fb1820bc7

docs: write authentication section 9b93cd97a6

docs: write rate limiting section 18e740bb73

docs: write home and users endpoint sections 2b84ed0de8

docs: write expense lists endpoint section ddf64305a5

docs: write data models section 2782823c3d

docs: write error handling section 7189e4fb08

docs: write recent changes section a5e5824a44

chore: merge feature/security-hardening into main ba4f365f06

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

chore: resolve merge conflicts, keep Spring Boot 4.0.6 version 50d274f36a

Kept our version over remote (security hardening PR #12) for all conflicts:
- pom.xml: Spring Boot 4.0.6 vs 3.4.1, new test deps
- SecurityConfig: new csrf/package API for SB4
- GlobalExceptionHandler: full handler set with SLF4J logging
- AppUserController/ExpenseListController: clean delegation to GlobalExceptionHandler
- Test files: SB4 package paths, extra test coverage

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Cedric added 2 commits 2026-05-10 21:25:28 +02:00

ci: test pipeline 46c8df45d6

ci: test pipeline 5549691d50

Cedric closed this pull request

2026-05-10 22:33:19 +02:00

Pull request closed

Please reopen this pull request to perform a merge.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Cedric/XpenselyServer#15