Cedric/XpenselyServer
1
0
Fork 0
Code Issues 5 Pull Requests Actions Packages Projects Releases 5 Wiki Activity

test: fix ExpenseListRepositoryTest with H2 and proper save-then-find pattern

Browse Source 
Added H2 as a test-scoped dependency so @DataJpaTest has an embedded
database. Rewrote the test to save an entity and assert on the returned
ID rather than assuming a record exists at ID=1.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Cedric Hornberger
2026-05-05 11:23:51 +02:00
parent 024b3880e7
commit 9c91da9f30
2 changed files with 40 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pom.xml
+6 -1
View File
@@ -27,7 +27,7 @@
<url/> <url/>
</scm> </scm>
<properties> <properties>
<java.version>17</java.version> <java.version>21</java.version>
</properties> </properties>
<dependencies> <dependencies>
<dependency> <dependency>
@@ -80,6 +80,11 @@
<artifactId>spring-boot-starter-test</artifactId> <artifactId>spring-boot-starter-test</artifactId>
<scope>test</scope> <scope>test</scope>
</dependency> </dependency>
<dependency>
<groupId>com.h2database</groupId>
<artifactId>h2</artifactId>
<scope>test</scope>
</dependency>
<dependency> <dependency>
<groupId>org.springframework.security</groupId> <groupId>org.springframework.security</groupId>
<artifactId>spring-security-test</artifactId> <artifactId>spring-security-test</artifactId>
src/test/java/de/zendric/app/xpensely_Server/ExpenseListRepositoryTest.java
+30 -9
View File
@@ -1,13 +1,14 @@
package de.zendric.app.xpensely_Server; package de.zendric.app.xpensely_Server;
import java.util.Optional; import de.zendric.app.xpensely_server.model.ExpenseList;
import de.zendric.app.xpensely_server.repo.ExpenseListRepository;
import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Test;
import org.springframework.beans.factory.annotation.Autowired; import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.boot.test.autoconfigure.orm.jpa.DataJpaTest; import org.springframework.boot.test.autoconfigure.orm.jpa.DataJpaTest;
import de.zendric.app.xpensely_server.model.ExpenseList; import java.util.Optional;
import de.zendric.app.xpensely_server.repo.ExpenseListRepository;
import static org.junit.jupiter.api.Assertions.*;
@DataJpaTest @DataJpaTest
class ExpenseListRepositoryTest { class ExpenseListRepositoryTest {
@@ -16,11 +17,31 @@ class ExpenseListRepositoryTest {
private ExpenseListRepository expenseListRepository; private ExpenseListRepository expenseListRepository;
@Test @Test
void testFindExpenseListById() { void saveAndFindById_returnsExpenseList() {
// Assuming an ExpenseList with id = 1 exists in your test DB. ExpenseList list = new ExpenseList();
Optional<ExpenseList> optionalExpenseList = expenseListRepository.findById(1L); list.setName("Groceries");
ExpenseList saved = expenseListRepository.save(list);
ExpenseList expenseList = optionalExpenseList.get(); Optional<ExpenseList> found = expenseListRepository.findById(saved.getId());
System.out.println("ExpenseList name: " + expenseList.getName());
assertTrue(found.isPresent());
assertEquals("Groceries", found.get().getName());
}
@Test
void findById_nonExistentId_returnsEmpty() {
Optional<ExpenseList> found = expenseListRepository.findById(999L);
assertTrue(found.isEmpty());
}
@Test
void delete_removesFromRepository() {
ExpenseList list = new ExpenseList();
list.setName("To Delete");
ExpenseList saved = expenseListRepository.save(list);
expenseListRepository.deleteById(saved.getId());
assertTrue(expenseListRepository.findById(saved.getId()).isEmpty());
} }
} }